Allow Symbolics facade reexports in MTKBase QA - #5047
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: OpenAI Codex <noreply@openai.com> Agent-Harness: Codex unknown Agent-Model: gpt-5 Agent-Session: local session ID 01a04feb-43da-7ce1-99e4-a68438c69833
|
Implementation scratchpad:
JET investigation update: #4958 (comment) |
|
CI triage update: The Runic workflow failed on three files unchanged by this PR:
The changed file, Per repository policy, a separate clean-master formatting investigation is in progress; this PR will not mix unrelated formatting changes into the reexport metadata fix. |
|
Runic follow-up: this is the known Runic 1.10 formatter drift already isolated in draft #5046. Clean |
|
CI triage is complete.
No failure unique to this patch was found. |
Ignore this PR until it has been reviewed by @ChrisRackauckas.
What changed and why
Symbolics 7.38 replaced its blanket SymbolicUtils reexport with explicit exports. That ownership correction made ModelingToolkitBase's strict reexport audit newly identify
Unknown,scalarize,shape, andunwrap, even though all four are already part of the intentional ModelingToolkitBase/Symbolics facade API.This adds those existing SymbolicUtils-owned facade names to
REEXPORTED_API; it does not widen the user-facing API. This is the ModelingToolkitBase counterpart to #5039.Verification
Failing before the change on clean
upstream/masteratf9131984d97460057c62830b60790380ee5fc2f1with Julia 1.12.7 and Symbolics 7.39.0:The other failure was the pre-existing package-wide JET result (
263 possible errors), tracked at #4958. The exact JET lane was already red with the same 263 reports in its first CI run after introduction by 92c27bb:https://github.com/SciML/ModelingToolkit.jl/actions/runs/31478008118/job/93737918032
Focused reexport audit after the change:
Full post-change QA:
Formatting and spelling:
All three completed with exit code 0 and no output.
Not verified
docs/.Links
🤖 Generated with Codex (harness version: unknown; model: gpt-5; session: local session ID
01a04feb-43da-7ce1-99e4-a68438c69833).