-
-
Notifications
You must be signed in to change notification settings - Fork 12
CompatHelper: bump compat for ForwardDiff in [weakdeps] to 1, (keep existing compat) #140
CompatHelper: bump compat for ForwardDiff in [weakdeps] to 1, (keep existing compat) #140
Conversation
Hi, could this be merged? :) |
It goes way deeper in the stack than here for now unfortunately, https://github.com/SciML/ModelingToolkit.jl/actions/runs/14320864845/job/40137331188?pr=3508#step:6:206. We'll merge it once CI can pass |
It's quite crazy how much stuff OptimizationBase seems to depend on. 😅 |
The tests don't seem to use e.g. |
@oscardssmith track this one too |
Checked locally and this is fine. |
Thanks for the fix! Would it be possible to backport it to OptimizationBase 1 as well, as we are still using Optimization 3? |
What keeps you back in the stone age? It's probably easier to fix that. If you want to do the testing for the backport though you can. |
Good question! I'll have a look and report back. Thanks. |
This pull request changes the compat entry for the
ForwardDiff
package from0.10.26
to0.10.26, 1
.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.