Performance optimization, refactoring and revamping. #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added supported_numericals_TF_DataType
- Cleanup and docs to all Tensor.cs files - Changed all uses of System.Convert to NumSharp.Utilities.Converts - Added all missing types in dtypes.cs - Renamed tensor.Data<T> to tensor.ToArray<T>, added obsolete message - Renamed tensor.Data() to tensor.BufferToArray(), added obsolete message - Made GraphKeys to use const string instead allocating strings at every use of GraphKeys.
…Item[] feed_dict)
- Fixed all locations _dtype is used incorrectly.
… eval(Session session, params FeedItem[] feed_dict)
…ues, ResetOutputValues They are managed by GC.
- Fixed all test cases to use using(Buffer) - Fixed all test cases to explicitly specify session
Oceania2018
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Oceania2018 Please review these changes to ensure I did not break anything I did not know of.
All unit tests pass. We still have the issue with shared static unit-tests.
I do plan to change our testing framework to NUnit as it allows isolation of unit-tests from one another.
Examples result the same as master branch before my changes.
Notable changes:
DisposableObject, their use cases has been reviewed and changed accordingly to allow GC decide when they are disposable.Buffer,StatusandBaseSessionBreaking changes:
public static implicit operator byte[](Buffer buffer)has been changed toexplicitmotivation: having such cast implicit might imply to the developer that it has no performance cost.