PoC fix issue 216 #217
Closed
PoC fix issue 216 #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsbarring
force-pushed
the
PoC_fix_issue_216
branch
from
4468a1a to
905fe65
Compare
|
Hrm, this was premature, naive and buggy .... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Added "parser" to check validity of date/time part of time unit string. The "parser" is in fact a low level private function from
cftime. Whether this is appropriate I am not sure, but implementing the same functionality more or less from scratch is beyond my capacity. [Hence the "PoC"].From the added unit tests it seems -- in principle -- that the examples in #216 are handled. Only "in principle" because the actual errors generated by the cftime function are not properly captured. But again, understanding how cython exceptions interact with pytest is too advanced for me.