Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for ruff rule D301 #5646

Merged
merged 3 commits into from
Dec 18, 2023
Merged

fix for ruff rule D301 #5646

merged 3 commits into from
Dec 18, 2023

Conversation

tkknight
Copy link
Contributor

@tkknight tkknight commented Dec 17, 2023

🚀 Pull Request

Description

PR solely for fixing D301: Use r""" if any backslashes in a docstring

Continues work of #5625.


Consult Iris pull request check list

Copy link

codecov bot commented Dec 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d0ee9c2) 89.69% compared to head (10d49a7) 89.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5646   +/-   ##
=======================================
  Coverage   89.69%   89.69%           
=======================================
  Files          90       90           
  Lines       22807    22807           
  Branches     5441     5441           
=======================================
  Hits        20456    20456           
  Misses       1618     1618           
  Partials      733      733           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tkknight tkknight changed the title fixed for ruff rule D301. fix for ruff rule D301. Dec 17, 2023
@tkknight tkknight changed the title fix for ruff rule D301. fix for ruff rule D301 Dec 17, 2023
@tkknight tkknight mentioned this pull request Dec 17, 2023
13 tasks
Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkknight Nice one, thanks 🍻

@bjlittle bjlittle merged commit 454c905 into SciTools:main Dec 18, 2023
17 checks passed
tkknight added a commit to tkknight/iris that referenced this pull request Dec 18, 2023
* upstream/main:
  ruff NPY rule compliance (SciTools#5653)
  ruff ICN rule compliance (SciTools#5652)
  ruff EXE rule compliance (SciTools#5651)
  ruff com rule compliance (SciTools#5650)
  Remove compliant ignored ruff rules (SciTools#5649)
  fix for ruff rule D301 (SciTools#5646)
  Updated environment lockfiles (SciTools#5645)
  Bump scitools/workflows from 2023.10.0 to 2023.12.1 (SciTools#5648)
@tkknight tkknight deleted the ruff1 branch January 9, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants