Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move docs/tephi to docs #165

Merged
merged 4 commits into from
Nov 14, 2024
Merged

move docs/tephi to docs #165

merged 4 commits into from
Nov 14, 2024

Conversation

ESadek-MO
Copy link
Contributor

part of #164

@ESadek-MO
Copy link
Contributor Author

Docs have built, and seem to be working fine

Copy link
Contributor

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find any references left over, LGTM!

@@ -17,7 +17,7 @@
import sys

# ensure tephi is discoverable by rtd build environment
root = pathlib.Path(__file__).absolute().parent.parent.parent.parent
root = pathlib.Path(__file__).absolute().parent.parent.parent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

Not sure who wrote this originally, but for future reference Pathlib supports:

Suggested change
root = pathlib.Path(__file__).absolute().parent.parent.parent
root = pathlib.Path(__file__).absolute().parents[2]

But I'm not going to hold up the review for this.

@trexfeathers trexfeathers merged commit 8257837 into SciTools:main Nov 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants