Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move tephi/tests to tests #167

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

ESadek-MO
Copy link
Contributor

part of #164

@pp-mo
Copy link
Member

pp-mo commented Nov 11, 2024

Warning ?

I think it's fair to say that we are having second thoughts on whether tests should be part of the package.

It had been raised in the past that including the tests made the Iris checkout + install rather bloated.
Since then we put the tests outside the package in both geovista, and ncdata.

But this approach has been found to have a few problems of its own :

  • tests can't be used to check install success
  • users can't (so easily) run the tests
  • the import of test submodules can be tricky, especially relative imports, as the tests aren't in a proper package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants