Skip to content

Conversation

@bcrosscxi
Copy link

Adds the Amazon ECR Docker Credential Helper.

Closes #6988

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

amazon-ecr-credential-helper

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Copy link
Member

@Lutra-Fs Lutra-Fs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see they are providing pre-computed hash in releases as well. Can you update the pr's autoupdate part to retrieve the hash in https://amazon-ecr-credential-helper-releases.s3.us-east-2.amazonaws.com/0.10.1/windows-amd64/docker-credential-ecr-login.exe.sha256 like this pattern?
Except that, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: amazon-ecr-credential-helper

2 participants