-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tools): update configuration file paths and directory structure #224
Conversation
- Modified the directory structure and file paths for configuration files in the Docker setup and application code. - Updated the amass configuration file path to be more organized under a dedicated directory. - Adjusted symbolic links and file handling logic to align with the new directory structure. - Enhanced the update_config function to accommodate the new file naming conventions.
Reviewer's Guide by SourceryThis PR reorganizes the configuration file structure for several security tools (theHarvester, GAU, and Amass) and updates their versions. The implementation involves updating file paths in the Docker setup, modifying symbolic links, and enhancing the configuration handling code to support the new directory structure. The changes also include version upgrades for various project discovery tools and a fix for a theHarvester bug. Class diagram for updated configuration handlingclassDiagram
class ConfigHandler {
+update_config(request, tool_name, display_name, file_name='config', file_extension='.yaml')
}
class AmassConfig {
+config_path: Path
}
class GauConfig {
+config_path: Path
}
class TheHarvesterConfig {
+config_path: Path
}
ConfigHandler --> AmassConfig : uses
ConfigHandler --> GauConfig : uses
ConfigHandler --> TheHarvesterConfig : uses
note for ConfigHandler "Handles updating of configuration files for different tools"
note for AmassConfig "Updated path to amass/config.ini"
note for GauConfig "Updated path to gau/config.toml"
note for TheHarvesterConfig "Updated path to theHarvester/api-keys.yaml"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
- Updated the path and usage of the GAU configuration file across multiple files to ensure consistency and correct file referencing. - Modified the command map in tasks.py to include the GAU configuration file path. - Adjusted the Dockerfile to copy the GAU configuration file to the correct location and removed unnecessary symbolic link creation. - Updated file path references in views.py and scanEngine/views.py to align with the new GAU configuration file path.
The changes standardize the casing of the ID and name attributes for the theHarvester configuration text area across JavaScript, HTML, and Python files. This involves updating the ID from theharvester_config_text_area to theHarvester_config_text_area to ensure consistency and improve code readability.
- Updated several Go-based tool dependencies to their latest versions in the Celery Dockerfile. - Modified the command in tasks.py to remove github-code sources for theHarvester due to this bug. laramies/theHarvester#1857 - Adjusted the column layout in the form_engine.html template to improve UI responsiveness.
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @psyray - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please complete the testing of updated tools and verify all new config paths are working as expected before merging this PR
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Corrected the reference for the s3scanner installation in the Celery Dockerfile to fix a typo in the commit hash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @psyray - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Fixes #223
Todo
Summary by Sourcery
Update configuration file paths and directory structure for tools in the Docker setup and application code. Fix a bug in theHarvester and enhance configuration handling to support new file naming conventions.
Bug Fixes:
Enhancements:
Build: