-
Notifications
You must be signed in to change notification settings - Fork 853
fix(build): check for CVEs before merge #6869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: fix/core-1-CVEs
Are you sure you want to change the base?
Conversation
4403ec1
to
9e4001d
Compare
Removed file argument from Snyk scan command.
Added SARIF output option for Snyk scan results and upload step.
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Updated RCLONE_IMAGE_TAG format and modified Snyk scan arguments.
Replaced snyk/actions/docker with direct Snyk CLI usage for container scanning.
Added echo statement to log return code after Snyk container test.
Updated Snyk action for Docker image scanning.
Motivation
Currently we have to merge PRs and then trigger a release and push images to docker hub to then scan them for CVEs. This is quite dangerous as we could be merging unsafe code and also causes long feedback loop, to know if a change has introduced a CVE.
Summary of changes
V1 Security Tests
we now build the images but do not push to a repo, and scan withsnyk
registry.access.redhat.com/ubi9/ubi-minimal:9.6
, removed thelatest
tag which would have achieved the same thing, but it's safer and gives a better audit trail to specify a specific tag.NOTE
Commented out building/scanning Alibi Detect as GH runner runs out of disk space. It is possible to build the image locally as we push the base image up to GH artifactory but not ideal. Potentially look at using private GH runner.
Checklist
Testing