Ladybird+Browser: Move config files from /home/anon/.config to /res/ladybird #26177
+124
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
|
Haven't looked at the diff, but let's use /res/browser. Ladybird is the standalone project. |
bplaat
force-pushed
the
multi-user-browser
branch
2 times, most recently
from
47d7eae to
f2d7b37
Compare
|
Isn't |
bplaat
force-pushed
the
multi-user-browser
branch
from
f2d7b37 to
cbf1625
Compare
You are totally right, I have changed the code to copy the both default config files to |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! |
bplaat
force-pushed
the
multi-user-browser
branch
from
cbf1625 to
b5aa64b
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! |
Except for the anon user that already has a prefilled bookmarkers.json file in the .config folder.
bplaat
force-pushed
the
multi-user-browser
branch
from
b5aa64b to
292928e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of #26164, currently new users coudn't start the Browser because of missing config files. I've moved these files to
/res/ladybird, and updated that folder layout as it currently exists in the Ladybird repo (https://github.com/LadybirdBrowser/ladybird/tree/master/Base/res/ladybird). This results in that a new user can open the Browser 🎉.I also changed that by default the Browser bookmarkers bar is hidden because it's empty for new users. Except for anon because there is already a filled
bookmarkers.jsonfile.These changes also work fine in Lagom.