LibSQL: Implement unique column constraint #26231
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parse UNIQUE keyword in CREATE TABLE column definitions, supporting both inline UNIQUE and named CONSTRAINT UNIQUE syntax. Updates the ColumnDefinition AST node to track unique constraint information.
Add unique constraint validation to INSERT and UPDATE operations. Column definitions now track unique constraints in metadata, and the database validates uniqueness before modifying data.
Mahmoud Abumandour is my legal name. I don't know why I was using "Mandour" for a last name in 2021. Also update copyright year to 2025
github-actions
bot
added
👀 pr-needs-review
|
Hm, shouldn't we start off by having support for unique table constraints though? The next step would be to have unique constraints on two or more columns, and then you'd have to rework this as a single-column table constraint anyway. |
nico
added
⏳ pr-waiting-for-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the UNIQUE column constraint. It's an attempt to revive this cool database implementation. This does a simple O(n) search for uniqueness; we may need to use a BTree index for better performance, but this is good as a first step.