image: Support --assign-color-profile sRGB
#26304
Merged
+21
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies the API quite a bit as we won't have to pass complicated `Variant`s around.
This will allow us to reuse this code for the `--assign-color-profile` option, and gain support for internal profiles (like "sRGB") there too.
This option is already supported in `--covert-to-color-profile`. And it allows invoking the tool this way: ``` $ image --assign-color-profile sRGB -o buggie-srgb.jpg buggie.png ```
github-actions
bot
added
the
👀 pr-needs-review
|
Thanks! This came out very nicely :) |
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes accessing the bad compression artifacts from our JPEG encoder even easier!