Remove retired isDomainIsolated flag from scaffolded package-solution.json - #266
Merged
svalenciasan merged 1 commit intoAug 12, 2026
Conversation
svalenciasan
force-pushed
the
remove-isdomainisolated-from-scaffold
branch
from
August 10, 2026 22:29
e4f4ab4 to
01046aa
Compare
….json The domain-isolated web parts feature is retired. Drop the dead isDomainIsolated flag from all scaffolding templates and their mirrored examples so new solutions no longer ship it, and update the multi-component test snapshot that captured it.
svalenciasan
force-pushed
the
remove-isdomainisolated-from-scaffold
branch
from
August 10, 2026 22:37
01046aa to
1f2e298
Compare
svalenciasan
marked this pull request as ready for review
August 11, 2026 18:14
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the retired isDomainIsolated flag from scaffolded config/package-solution.json across all templates and their mirrored examples, and updates the relevant snapshot so newly scaffolded solutions no longer include this dead/ignored surface area.
Changes:
- Removed
"isDomainIsolated": falsefrom alltemplates/**/config/package-solution.json. - Removed
"isDomainIsolated": falsefrom allexamples/**/config/package-solution.jsonto keep templates/examples in sync. - Updated
multi-component.test.ts.snapto match the new scaffolded output.
Reviewed changes
Copilot reviewed 41 out of 41 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/spfx-template-test/src/tests/snapshots/multi-component.test.ts.snap | Updates snapshot output to no longer expect isDomainIsolated. |
| templates/webpart-react/config/package-solution.json | Drops retired isDomainIsolated from the template scaffold output. |
| templates/webpart-noframework/config/package-solution.json | Drops retired isDomainIsolated from the template scaffold output. |
| templates/webpart-minimal/config/package-solution.json | Drops retired isDomainIsolated from the template scaffold output. |
| templates/library/config/package-solution.json | Drops retired isDomainIsolated from the template scaffold output. |
| templates/extension-search-query-modifier/config/package-solution.json | Drops retired isDomainIsolated from the template scaffold output. |
| templates/extension-listviewcommandset/config/package-solution.json | Drops retired isDomainIsolated from the template scaffold output. |
| templates/extension-formcustomizer-react/config/package-solution.json | Drops retired isDomainIsolated from the template scaffold output. |
| templates/extension-formcustomizer-noframework/config/package-solution.json | Drops retired isDomainIsolated from the template scaffold output. |
| templates/extension-fieldcustomizer-react/config/package-solution.json | Drops retired isDomainIsolated from the template scaffold output. |
| templates/extension-fieldcustomizer-noframework/config/package-solution.json | Drops retired isDomainIsolated from the template scaffold output. |
| templates/extension-fieldcustomizer-minimal/config/package-solution.json | Drops retired isDomainIsolated from the template scaffold output. |
| templates/extension-application-customizer/config/package-solution.json | Drops retired isDomainIsolated from the template scaffold output. |
| templates/copilot-component-react/config/package-solution.json | Drops retired isDomainIsolated from the template scaffold output. |
| templates/copilot-component-noframework/config/package-solution.json | Drops retired isDomainIsolated from the template scaffold output. |
| templates/copilot-component-minimal/config/package-solution.json | Drops retired isDomainIsolated from the template scaffold output. |
| templates/ace-search-card/config/package-solution.json | Drops retired isDomainIsolated from the template scaffold output. |
| templates/ace-generic-primarytext-card/config/package-solution.json | Drops retired isDomainIsolated from the template scaffold output. |
| templates/ace-generic-image-card/config/package-solution.json | Drops retired isDomainIsolated from the template scaffold output. |
| templates/ace-generic-card/config/package-solution.json | Drops retired isDomainIsolated from the template scaffold output. |
| templates/ace-data-visualization/config/package-solution.json | Drops retired isDomainIsolated from the template scaffold output. |
| examples/webpart-react/config/package-solution.json | Mirrors template change by dropping retired isDomainIsolated. |
| examples/webpart-noframework/config/package-solution.json | Mirrors template change by dropping retired isDomainIsolated. |
| examples/webpart-minimal/config/package-solution.json | Mirrors template change by dropping retired isDomainIsolated. |
| examples/library/config/package-solution.json | Mirrors template change by dropping retired isDomainIsolated. |
| examples/extension-search-query-modifier/config/package-solution.json | Mirrors template change by dropping retired isDomainIsolated. |
| examples/extension-listviewcommandset/config/package-solution.json | Mirrors template change by dropping retired isDomainIsolated. |
| examples/extension-formcustomizer-react/config/package-solution.json | Mirrors template change by dropping retired isDomainIsolated. |
| examples/extension-formcustomizer-noframework/config/package-solution.json | Mirrors template change by dropping retired isDomainIsolated. |
| examples/extension-fieldcustomizer-react/config/package-solution.json | Mirrors template change by dropping retired isDomainIsolated. |
| examples/extension-fieldcustomizer-noframework/config/package-solution.json | Mirrors template change by dropping retired isDomainIsolated. |
| examples/extension-fieldcustomizer-minimal/config/package-solution.json | Mirrors template change by dropping retired isDomainIsolated. |
| examples/extension-application-customizer/config/package-solution.json | Mirrors template change by dropping retired isDomainIsolated. |
| examples/copilot-component-react/config/package-solution.json | Mirrors template change by dropping retired isDomainIsolated. |
| examples/copilot-component-noframework/config/package-solution.json | Mirrors template change by dropping retired isDomainIsolated. |
| examples/copilot-component-minimal/config/package-solution.json | Mirrors template change by dropping retired isDomainIsolated. |
| examples/ace-search-card/config/package-solution.json | Mirrors template change by dropping retired isDomainIsolated. |
| examples/ace-generic-primarytext-card/config/package-solution.json | Mirrors template change by dropping retired isDomainIsolated. |
| examples/ace-generic-image-card/config/package-solution.json | Mirrors template change by dropping retired isDomainIsolated. |
| examples/ace-generic-card/config/package-solution.json | Mirrors template change by dropping retired isDomainIsolated. |
| examples/ace-data-visualization/config/package-solution.json | Mirrors template change by dropping retired isDomainIsolated. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Nick Pape (nick-pape)
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The domain-isolated web parts feature is retired. Freshly scaffolded SPFx solutions still emitted
"isDomainIsolated": falseinconfig/package-solution.json, which is dead surface area that confuses developers reading the manifest. This removes the flag from all scaffolding templates and their mirrored examples so new solutions no longer ship it.Existing solutions that still carry the flag are unaffected — the property is tolerated and ignored by the build.
Related
Companion platform-side change (Microsoft-internal Azure DevOps): removes
isDomainIsolatedfrom the SPFx generator/build pipeline and graduates the domain-isolated WP retirement flight — ODSP-Web PR 2331347: https://onedrive.visualstudio.com/ODSP-Web/_git/odsp-web/pullrequest/2331347How was this tested
isDomainIsolatedremains undertemplates/orexamples/.package-solution.jsonfiles still parse as valid JSON.Type of change
Draft — not for review yet.