fix: $.isBase64(str)の関数で audio, video の形式も受け入れるように変更#128
Open
Ouvill wants to merge 1 commit intoShikemokuMK:masterfrom
Open
fix: $.isBase64(str)の関数で audio, video の形式も受け入れるように変更#128Ouvill wants to merge 1 commit intoShikemokuMK:masterfrom
Ouvill wants to merge 1 commit intoShikemokuMK:masterfrom
Conversation
playseのstorageにdata-urlのバイナリデータを渡しても音が鳴るようになります。 ## 備考 - isBase64 という関数名ですが、isDataUrlという関数名にしたほうが良いかもしれません。 - imageを受け入れたいとき、audioを受け入れたいとき、videoを受け入れたいときと区別するべきかもしれません。 - 判定方法が甘くdata-urlの一部しかtrueになりません。また厳密にdata-urlの要件を満たしていないものでも`true`になりえます。
|
I doubt that this pull request will be accepted. It has been 2 years since they made a commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
playseのstorageにdata-urlのバイナリデータを渡しても音が鳴るようになります。
備考
trueになりえます。#127