feat!(sim): Use g4Config.yaml instead of deprecated .C#841
Closed
feat!(sim): Use g4Config.yaml instead of deprecated .C#841
Conversation
Contributor
Author
|
Fails because I'll return to this when I'm back (or left as exercise for the reader). |
Contributor
Author
|
Build failure should be fixed once we switch the CI to a config using ShipSoft/shipdist#115 |
olantwin
force-pushed
the
gconfig_yaml
branch
5 times, most recently
from
71d6cf4 to
7fc8a1c
Compare
Contributor
Author
|
First results look ok. More detailed testing needed, but particle and hit distributions look normal. |
Contributor
Author
|
@siilieva Probably also of interest for SND@(HL-)LHC |
Contributor
Author
|
It should be possible to test whether the same set of options reach geant4 and that the stack is the same. |
olantwin
force-pushed
the
gconfig_yaml
branch
6 times, most recently
from
4340bdd to
fd5de32
Compare
olantwin
force-pushed
the
gconfig_yaml
branch
from
ed81f40 to
db81745
Compare
Replace g4Config.C/g4Config_basic.C with g4Config.yaml/g4Config_basic.yaml for Geant4 VMC configuration. Add SHiP::VMCConfig class inheriting from FairYamlVMCConfig to handle ShipStack setup and conditional UseGeneralProcess disabling (via SET_GENERAL_PROCESS_TO_FALSE env var for boost factor studies). VMCConfig and SetupVMCConfig free function are registered in the ROOT dictionary (LinkDef with namespace, class, and function pragmas) so that PyROOT can call ROOT.SHiP.SetupVMCConfig() directly. yaml-cpp is added as an explicit dependency to ensure rootcling receives its include paths. YAML configs updated to match current master: FTFP_BERT_HP_EMZ physics list, J/psi external decayer selection. Closes #543
olantwin
force-pushed
the
gconfig_yaml
branch
from
7820518 to
0477228
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add YAML config including all settings from .C. Set ShipStack and its options explicitly in simulation scripts.
Thorough testing needed.
Fixes #543