Merged
Conversation
Contributor
Author
kdaviduik
changed the base branch from
kd-update-to-typescript
to
graphite-base/942
kdaviduik
force-pushed
the
03-09-feat_migrate_yarn_v1_to_pnpm
branch
from
213bf77 to
ee4846e
Compare
kdaviduik
changed the base branch from
graphite-base/942
to
03-09-fix_remove_firefox_requirement_from_testem_ci_config_and_fix_view_tests
kdaviduik
force-pushed
the
03-09-fix_remove_firefox_requirement_from_testem_ci_config_and_fix_view_tests
branch
from
731bb4a to
cdb7712
Compare
kdaviduik
force-pushed
the
03-09-feat_migrate_yarn_v1_to_pnpm
branch
from
ee4846e to
6adb227
Compare
kdaviduik
force-pushed
the
03-09-fix_remove_firefox_requirement_from_testem_ci_config_and_fix_view_tests
branch
from
cdb7712 to
d65c289
Compare
kdaviduik
force-pushed
the
03-09-feat_migrate_yarn_v1_to_pnpm
branch
2 times, most recently
from
c394251 to
a65405e
Compare
This was referenced Mar 9, 2026
Replace Yarn v1 with pnpm as the package manager. Update all package.json scripts from yarn/npm to pnpm, add pnpm-lock.yaml, remove yarn.lock, configure .npmrc for pnpm, and update CI workflow to use pnpm with frozen lockfile. Add a 'Build generated styles' step in CI before lint because src/styles/embeds/all.js and src/styles/host/main.js are generated files (gitignored) that ESLint's import/no-unresolved rule needs to resolve. pnpm install does not trigger lifecycle scripts that generate them, unlike npm install.
kdaviduik
force-pushed
the
03-09-fix_remove_firefox_requirement_from_testem_ci_config_and_fix_view_tests
branch
from
d65c289 to
a79416c
Compare
kdaviduik
force-pushed
the
03-09-feat_migrate_yarn_v1_to_pnpm
branch
from
a65405e to
12b544b
Compare
fredericoo
approved these changes
Mar 11, 2026
Base automatically changed from
03-09-fix_remove_firefox_requirement_from_testem_ci_config_and_fix_view_tests
to
main
March 11, 2026 15:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace Yarn v1 with pnpm 10 as the package manager.
shamefully-hoist is temporary: needed until browserify is replaced
by Vitest (PR 7a). enable-pre-post-scripts is permanent: the project
uses pretest and prepublishOnly lifecycle hooks.