-
Notifications
You must be signed in to change notification settings - Fork 58
[DO NOT MERGE] Upgrade to react router #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
byrichardpowell
wants to merge
14
commits into
main
Choose a base branch
from
upgrade-to-react-router
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f3bc0a7
CLI: Upgrade to the latest version of the CLI by removing the local d…
byrichardpowell 831baeb
Vite: Followed the Migrate your app to Vite guide: https://github.com…
byrichardpowell 951e00f
Future flag: Update tsconfig to match https://remix.run/docs/en/main/…
byrichardpowell 3187c7c
Future flag: Adopt v3_singleFetch to match https://remix.run/docs/en/…
byrichardpowell a269d36
Future flag: Enable v3_routeConfig as per https://remix.run/docs/en/m…
byrichardpowell ae9a90a
Future flag: Adopt v3_lazyRouteDiscovery, v3_throwAbortReason, v3_rel…
byrichardpowell 25ebf46
Future flag: Update tsconfig to match https://remix.run/docs/en/main/…
byrichardpowell 162a6e7
React Router: Ran npx codemod remix/2/react-router/upgrade && npm ins…
byrichardpowell ad8c613
React Router: Enabled Typesafety in React Router as per https://react…
byrichardpowell 1b830d9
Shopify App: Swap @shopify/shopify-app-remix for @shopify/shopify-app…
byrichardpowell 7e2ee0d
Shopify App: Update AppProvider, since the AppProvider from @shopify/…
byrichardpowell bead872
Shopify App: Polaris React to Polaris WC. Migrate the Custom App UI f…
byrichardpowell 0fadbf5
Fix issue where QR Code could not be saved
byrichardpowell 96d02a4
Merge pull request #35 from Shopify/fix-react-router-reported-issues
byrichardpowell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| /// <reference types="vite/client" /> | ||
| /// <reference types="@react-router/node" /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,5 @@ | ||
| node_modules | ||
| build | ||
| public/build | ||
| shopify-app-remix | ||
| */*.yml | ||
| .shopify |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| /** | ||
| * This is intended to be a basic starting point for linting in your app. | ||
| * It relies on recommended configs out of the box for simplicity, but you can | ||
| * and should modify this configuration to best suit your team's needs. | ||
| */ | ||
|
|
||
| /** @type {import('eslint').Linter.Config} */ | ||
| module.exports = { | ||
| root: true, | ||
| parserOptions: { | ||
| ecmaVersion: "latest", | ||
| sourceType: "module", | ||
| ecmaFeatures: { | ||
| jsx: true, | ||
| }, | ||
| }, | ||
| env: { | ||
| browser: true, | ||
| commonjs: true, | ||
| es6: true, | ||
| }, | ||
| ignorePatterns: ["!**/.server", "!**/.client"], | ||
|
|
||
| // Base config | ||
| extends: ["eslint:recommended"], | ||
|
|
||
| overrides: [ | ||
| // React | ||
| { | ||
| files: ["**/*.{js,jsx,ts,tsx}"], | ||
| plugins: ["react", "jsx-a11y"], | ||
| extends: [ | ||
| "plugin:react/recommended", | ||
| "plugin:react/jsx-runtime", | ||
| "plugin:react-hooks/recommended", | ||
| "plugin:jsx-a11y/recommended", | ||
| ], | ||
| settings: { | ||
| react: { | ||
| version: "detect", | ||
| }, | ||
| formComponents: ["Form"], | ||
| linkComponents: [ | ||
| { name: "Link", linkAttribute: "to" }, | ||
| { name: "NavLink", linkAttribute: "to" }, | ||
| ], | ||
| "import/resolver": { | ||
| typescript: {}, | ||
| }, | ||
| }, | ||
| }, | ||
|
|
||
| // Typescript | ||
| { | ||
| files: ["**/*.{ts,tsx}"], | ||
| plugins: ["@typescript-eslint", "import"], | ||
| parser: "@typescript-eslint/parser", | ||
| settings: { | ||
| "import/internal-regex": "^~/", | ||
| "import/resolver": { | ||
| node: { | ||
| extensions: [".ts", ".tsx"], | ||
| }, | ||
| typescript: { | ||
| alwaysTryTypes: true, | ||
| }, | ||
| }, | ||
| }, | ||
| extends: [ | ||
| "plugin:@typescript-eslint/recommended", | ||
| "plugin:import/recommended", | ||
| "plugin:import/typescript", | ||
| ], | ||
| }, | ||
|
|
||
| // Node | ||
| { | ||
| files: [".eslintrc.cjs"], | ||
| env: { | ||
| node: true, | ||
| }, | ||
| }, | ||
|
|
||
| // Node/Server files | ||
| { | ||
| files: [ | ||
| "**/*.server.{js,jsx,ts,tsx}", | ||
| "vite.config.{js,ts}", | ||
| "app/routes/**/*.{js,jsx,ts,tsx}", | ||
| ], | ||
| env: { | ||
| node: true, | ||
| }, | ||
| }, | ||
| ], | ||
| }; |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,6 @@ build | |
| node_modules | ||
| prisma | ||
| public | ||
| shopify-app-remix | ||
| .github | ||
| tmp | ||
| *.yml | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| import { flatRoutes } from "@react-router/fs-routes"; | ||
|
|
||
| export default flatRoutes(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.