[DO NOT MERGE] Update readme #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the README to replace references to Remix with React Router throughout.
- Updated title and tutorial callouts from Remix to React Router
- Replaced local development commands and removed package-manager-specific steps
- Adjusted Tech Stack and Resources links to point to React Router equivalents
Comments suppressed due to low confidence (2)
README.md:3
- The link target still points to the generic
build-qr-code-apptutorial; verify that this URL now serves the React Router version or update it to the correct React Router tutorial path.
This is a Shopify app for managing QR codes. It is the code for the [Build a Shopify app using React Router tutorial](https://shopify.dev/docs/apps/getting-started/build-qr-code-app).
README.md:32
- The setup step (
pnpm run setup) was removed; ensure any required initialization is documented (or confirm thatshopify app devcovers setup automatically).
-pnpm run setup
byrichardpowell
force-pushed
the
upgrade-to-react-router
branch
2 times, most recently
from
c1ca960 to
80d72b2
Compare
byrichardpowell
force-pushed
the
upgrade-to-react-router
branch
6 times, most recently
from
0d6569a to
e66466f
Compare
…ency, then expressing the predev command in the sopify.web.toml
…main/start/future-flags#v3_singlefetch Adopting this flag requires: 1. Adding everywhere that calls authenticate.admin(). In the template, there is just one place where this is missing, which is why I added it to app._index.tsx 2. Adding declare module @remix-run/node to the vite.config.ts file 3. Removing json() from every loader/action that uses it
…ativeSplatPath and v3_fetcherPersist
…fy-app-react-router
byrichardpowell
force-pushed
the
upgrade-to-react-router
branch
6 times, most recently
from
6f8382f to
925968d
Compare
…shopify-app-react-router is simpler
byrichardpowell
force-pushed
the
upgrade-to-react-router
branch
from
925968d to
35b47ba
Compare
byrichardpowell
force-pushed
the
upgrade-to-react-router
branch
7 times, most recently
from
1d7f86f to
24bfed3
Compare
…or creating, editing & deleting QR codes.
byrichardpowell
force-pushed
the
upgrade-to-react-router
branch
from
24bfed3 to
7d1f914
Compare
byrichardpowell
force-pushed
the
update-readme
branch
from
2b10188 to
791fe7a
Compare
byrichardpowell
force-pushed
the
update-readme
branch
from
791fe7a to
6f81936
Compare
byrichardpowell
force-pushed
the
upgrade-to-react-router
branch
2 times, most recently
from
3abf441 to
6a5a658
Compare
byrichardpowell
force-pushed
the
upgrade-to-react-router
branch
from
7e05b88 to
bead872
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates references to Remix in the README to reference React Router instead.
DO NOT MERGE
I do not want these changes in the base branch (upgrade-to-react-router). Once we mereg this branch I'll rebase this PR and merge with main.
We can still review though