Skip to content

Update location rules templates to new target #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: update-function-templates-2025-07
Choose a base branch
from

Conversation

hamishmorgan
Copy link

@hamishmorgan hamishmorgan commented May 7, 2025

Part of the ongoing project to rationalise the function API

gsd#44156 | doc | style guide | slack

This PR updates the Order Routing Location Rules templates

Specifically:

  • Pulled the latest schema. (shopify app function schema in an location rules extension with the function_renaming_breaking_changes_api flag enabled, and the order_routing_extensibility_partner partner flag enabled.) The diff is a bit scary because it hasn't been updated in ages.
  • Updated the sample code, replacing the target handle and result types.
  • Bumped the version to 2025-07 where appropriate

@hamishmorgan hamishmorgan self-assigned this May 7, 2025
@hamishmorgan hamishmorgan requested review from maximus1108 and tjoyal May 7, 2025 14:53
Copy link
Member

@tjoyal tjoyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I see here looks good.

Approving, but either here or as a followup PR we'll need to update the export name and GraphQL schema file name as per #623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants