Fix handling of hexadecimal escapes in escape_once #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also aligns the behavior once again with current behavior of ActionView::Helpers::TagHelper#escape_once / ERB::Util::html_escape_once, which escape_once was originally based on. Fixes Shopify#792
cr7pt0gr4ph7
force-pushed
the
escape_once
branch
from
697c1ec
to
8ad8b43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also aligns the behavior once again with current behavior of
ActionView::Helpers::TagHelper#escape_once/ERB::Util::html_escape_once(whichescape_oncewas originally based on).Fixes #792 (That bug was closed because of an available fix, but the fix was never merged).