feature: Allow the scope to be passed in as an array.#42
feature: Allow the scope to be passed in as an array.#42dylanahsmith wants to merge 1 commit intomainfrom
Conversation
|
Awesome! 👍 |
|
I'm not sure this is a good idea because no omniauth provider work this way, this is completely custom and likely won't be expected by people who have dealt with other omniauth strategy providers in the past. |
|
Well, it doesn't look like we can propose doing this upstream, since I just looked at what the Oauth2 spec says about the scope parameter, and it says:
which would suggest that |
That's strange. Omniauth strategies I've seen all seem to use commas. https://github.com/intridea/omniauth-github#scopes |
|
Oh, well I just went by what I read on https://tools.ietf.org/html/rfc6749#section-3.3 |
@EiNSTeiN- for review
cc @minasmart
Based on recommendation in issue #41
This allows the scope to be passed in as an array of strings, which is more natural for a ruby API