Fix method_receiver for self at class body level

[alexcrocha]

Fixes #657

At class body level, self is the class object. Method calls on it (self.bar, bar, Foo.bar) all resolve through the singleton class. method_receiver was not setting is_singleton_name in the SelfNode | None arm for Class, Module, and SingletonClass definitions, so self.bar inside class Foo returned receiver Foo while Foo.bar returned <Foo>.

Now all three produce <Foo> consistently.

Tests

Test	Ruby source	Expected receiver
self_at_class_level_matches_constant	self.bar inside class Foo vs Foo.baz outside	Both <Foo>
implicit_at_class_level	bar inside class Foo	<Foo>
self_at_module_level	self.bar inside module Foo	<Foo>
self_inside_singleton_class	self.bar inside class << self	<<Foo>>
implicit_inside_singleton_class	bar inside class << self	<<Foo>>
at_top_level	self.bar at top level	Object

Count assertions in indexing_the_same_document_twice updated: alias_method calls at class body level now create singleton names and constant references.

[alexcrocha]

• Fix method_receiver for self at class body level #662 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[st0012]

Should we create singleton class for attr_reader calls too? If not, should we stop creating one for alias_method calls? Can be a follow up PR

[alexcrocha]

That's a fair question. Let's do a follow up PR for this. I don't know the answer yet but I'll leave it for tomorrow