Closed
Conversation
Member
I think we should fix this root problem, instead of adding ignores for namespaces. If the attribution of methods/constants to gems is wrong, we should fix that. I actually think #293 might already fix this problem. |
Author
|
I'm not sure #293 would fix it because both sources define the methods, but I'll be honest I don't fully understand how tapioca works
Sure... but how? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In one of our repos we're loading the same gem
fooboth in a dependency (gembar), and directly in the host project. Thisfoogem is then generated with tapioca both as part ofsorbet/rbi/gem/foo@version.rbiandbar@version.rbi.The problem lies in that
foosignatures that can't be loaded twice by Sorbet, such attype_memberandalias.I've been able to sidestep the problem so far by having
typed_overrides -> "ignore"and manually creating annotations for the gem, but the list of constants required grows every day and this is untenable. What I really need is to be able to say "ignorefooas generated inbar". This is what this PR does.I haven't exposed this to the
config.ymlfile yetImplementation
This PR is the most bare-bones it can be; I just want to have a starting point for the discussion.
Tests
Basic test to show what I expect it to do.