Conversation
c90939c to
7183f11
Compare
tmgsca
approved these changes
Mar 10, 2026
af47cbd to
d7c1532
Compare
d7c1532 to
ea85e19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change accomplish?
This change updates how errors are displayed when using
tophatctl. Previously,tophatctlwas purely a remote control for the UI, so all errors were displayed as AppKit alerts. With this change, errors are no longer displayed in the UI fortophatctl-triggered operations and are instead printed to the command line, along with nonzero exit code.How have you achieved it?
InstallCoordinatordirectly inremoteControlReceiverdelegate methods sinceInstallAppActionis purely for UI-initiated installs.InstallAppAction.ErrorNotifierandRemoteControlReceiver(which now returns the error messages in the reply) can both use it.Installcommand accordingly to send/receive the error data.How can the change be tested?
Run
tophatctlwith input that will cause installation to fail and ensure that the error message is printed to the CLI with nonzero exit. Also ensure that existing installation flows that produce error (especially UI-initiated) are still working and display errors in UI alerts.