Suppress Android codename returned by avdmanager#124
Merged
Conversation
lfroms
force-pushed
the
clean-up-android-versions
branch
from
75ca530 to
d767f79
Compare
tmgsca
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change accomplish?
This change fixes an issue where Android version codenames were sneaking into the runtime information for a device, even though the
.exactversion should always be a numerical/semantic version. This doesn't cause any bugs, but fixing this improves user experience (especially where specifying an Android version is necessary).How have you achieved it?
By updating the RegexBuilder logic to intentionally match codenames so that they are not included in the version capture, and updating the
ProxyVirtualDevice's existing logic accordingly.How can the change be tested?
Open Tophat and ensure that you still see all Android devices, and that they all use standard version labels like
Android 15.0.