-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add purchase options card extensions #2387
base: unstable
Are you sure you want to change the base?
Conversation
We detected some changes in |
|
||
export interface PurchaseOptionsCardConfigurationApi< | ||
ExtensionTarget extends AnyExtensionTarget, | ||
> extends StandardApi<ExtensionTarget> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you will want to extend ActionExtensionApi
here, or just add the close
method from that type (I forget if extends
can override a property, in this case data
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have to wait to merge this until the 2024-10
branch has been created
Yes |
c597ccb
to
e8eb8ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: should we show a puzzlify
header to match the other screenshots in this page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, will change that 👍
From our perspective, LGTM. |
Background
Closes https://github.com/Shopify/subscriptions-app-remix/issues/1642, shipping for 2025-01, but will make it on unstable mid-october
Adding the UI extension action for the purchase options card in the product page and product variant page.
The extension target are named:
admin.product-purchase-option.action.render
admin.product-variant-purchase-option.action.render
This should be release as the same as we are releasing our new extensions by enabling our beta flag.
We do also have a PR for the documentation of these targets.
This PR add the related documentations on Shopify-dev
🎩
Checklist