Add shouldRender method to ui-extensions #2458
Open
+326
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/snapit |
|
🫰✨ Thanks @elanalynn! Your snapshots have been published to npm. Test the snapshots by updating your "@shopify/data-extensions": "0.0.0-snapshot-20241106220158",
"@shopify/ui-extensions": "0.0.0-snapshot-20241106220158",
"@shopify/ui-extensions-react": "0.0.0-snapshot-20241106220158" |
belalsj
reviewed
Nov 7, 2024
elanalynn
force-pushed
the
ek/add-should-render-method
branch
2 times, most recently
from
a797cef
to
09e4ef5
Compare
elanalynn
force-pushed
the
ek/add-should-render-method
branch
from
09e4ef5
to
4a71d84
Compare
|
/snapit |
|
🫰✨ Thanks @elanalynn! Your snapshots have been published to npm. Test the snapshots by updating your "@shopify/data-extensions": "0.0.0-snapshot-20241107212535",
"@shopify/ui-extensions": "0.0.0-snapshot-20241107212535",
"@shopify/ui-extensions-react": "0.0.0-snapshot-20241107212535" |
elanalynn
force-pushed
the
ek/add-should-render-method
branch
from
4a71d84
to
e1e195c
Compare
developit
reviewed
Nov 13, 2024
packages/ui-extensions/src/utilities/shouldRenderRegistration.ts
Outdated
Show resolved
Hide resolved
|
/snapit |
|
🫰✨ Thanks @elanalynn! Your snapshots have been published to npm. Test the snapshots by updating your "@shopify/data-extensions": "0.0.0-snapshot-20241113210423",
"@shopify/ui-extensions": "0.0.0-snapshot-20241113210423",
"@shopify/ui-extensions-react": "0.0.0-snapshot-20241113210423" |
belalsj
approved these changes
Nov 14, 2024
js-goupil
reviewed
Nov 14, 2024
packages/ui-extensions/src/utilities/shouldRenderRegistration.ts
Outdated
Show resolved
Hide resolved
vividviolet
requested changes
Nov 14, 2024
packages/ui-extensions/src/surfaces/admin/api/should-render/should-render.ts
Show resolved
Hide resolved
packages/ui-extensions/src/utilities/shouldRenderRegistration.ts
Outdated
Show resolved
Hide resolved
vividviolet
reviewed
Nov 14, 2024
packages/ui-extensions/src/surfaces/admin/should-render-targets.ts
Outdated
Show resolved
Hide resolved
packages/ui-extensions/src/surfaces/admin/should-render-targets.ts
Outdated
Show resolved
Hide resolved
packages/ui-extensions/src/surfaces/admin/should-render-targets.ts
Outdated
Show resolved
Hide resolved
elanalynn
force-pushed
the
ek/add-should-render-method
branch
from
3090c84
to
2b43f0f
Compare
elanalynn
force-pushed
the
ek/add-should-render-method
branch
from
2b43f0f
to
a68c13a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Part of the project for conditional rendering admin extensions, we need to introduce a
shouldRendermethod to register the functions that control the rendering of the action extensions.Solution
shouldRendermethod🎩
For complete e2e testing of conditional rendering, see instruction here.
You can just test that this version of
ui-extensionsworks by pointing the reference in the extension'spackage.json"@shopify/ui-extensions": "0.0.0-snapshot-20241107212535".You should be able to import the
shouldRendermethod from@shopify/ui-extensionsand use it in your extension.Checklist