Enable using AWS services with ec2role #343
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dhaval055 can you have a look at this? It's a possibly breaking change to a lot of existing apps, so I think we should bump all relevant apps to at least 1.1.0. It looks really nice @mesutgungor - thanks 🔥 Hope it works :) |
|
@dhaval055 tagged wrong dhaval.. oops :D |
|
I have tested locally everything seems working @frikky, happy to contribute. |
added 2 commits
March 15, 2023 13:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally in Shuffle AWS apps needs credentials to be used.
If you give a necessary permissions(list bucket, create waf block ip etc.) with an ec2role to the server that Shuffle installed then you don't need to enter credentials in the app.
I put a small check for this in the code and change the requirements in the api.yaml