chore(frontend): move shared chart and variable code out of the v1 namespace (phase 4) - #12544
Draft
ahrefabhi wants to merge 1 commit into
Draft
Conversation
…mespace container/DashboardContainer held nothing but shared code once the v1 dashboard was deleted — a directory named after a component that no longer exists. - visualization/ -> container/Visualization (v2 panels, PanelWrapper, API Monitoring, Billing, Meter Explorer, TimeSeriesView, alert previews) - the variable helpers and addTagFiltersToDashboard -> container/DashboardVariables - PanelTypeSelectionModal/menuItems -> container/Visualization/panelTypeMenuItems Pure relocation: no file contents changed beyond import paths. Assisted-by: Claude Opus 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stacked on #12543, which is stacked on #12542 — review those first; this diff is against the phase 2 branch.
Pure relocation, no behaviour change. After phase 1 removed the v1 dashboard,
container/DashboardContainerheld nothing but shared code — a directory named after a component that no longer exists.DashboardContainer/visualization/→container/Visualization/— the chart and panel primitives behind the v2 panels,PanelWrapper, API Monitoring, Billing, Meter Explorer,TimeSeriesViewand alert previews.DashboardVariablesSelection/{util,useDashboardVariableUpdate}andDashboardVariableSettings/addTagFiltersToDashboard→container/DashboardVariables/, together with their tests.PanelTypeSelectionModal/menuItems→container/Visualization/panelTypeMenuItems.container/DashboardContaineris now gone. Nothing outside import paths changed — worth reviewing with whitespace and rename detection on.Additional Information
Verification:
tsgo --noEmit,lint:js,stylelintandbuildclean; 224 suites / 1790 tests pass across every consumer of the moved modules. I checked that the formatter introduced no unrelated churn — every modified file's diff touches one of the moved paths.Not included, deliberately:
container/GridCardLayoutstill carries a name that stopped being accurate when phase 1 deletedGridCardLayout.tsx, and the shared leaves undercontainer/NewWidget(timeItems,alertFomatCategories,Threshold/types,PlotTag,NewWidget/utils, …) are still in the retired editor's directory. Both are worth renaming, but each is its own large diff and neither is v1-branded, so they are lower priority than this one.🤖 Generated with Claude Code