Update Nslookup PowerShell Download Cradle Rule with Extended Coverage #5211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Rules
Windows
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome @HannesWid 👋
It looks like this is your first pull request on the Sigma rules repository!
Please make sure to read the SigmaHQ conventions document to make sure your contribution is adhering to best practices and has all the necessary elements in place for a successful approval.
Thanks again, and welcome to the Sigma community! 😃
nasbench
approved these changes
Feb 25, 2025
frack113
approved these changes
Feb 26, 2025
frack113
added
Ready to Merge
and removed
2nd Review Needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This pull request updates Nslookup PowerShell Download Cradle to include a variation where '-type=txt http' is used instead of the other two conditionals. The -type parameter functions the same way as the existing conditions, ensuring consistent behavior.
Reference: Microsoft Documentation - NSLookup Set Type
Changelog
update: Nslookup PowerShell Download Cradle - add condition '-type=txt http'
Example Log Event
Fixed Issues
SigmaHQ Rule Creation Conventions