Upgrade AGP and replace kotlin-android-extensions with viewbinding #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the build setup and replaces Kotlin synthetic view binding with Android View Binding across the app.
- Upgrades Gradle wrapper to 8.5, compileSdk/targetSdk to 35, and applies viewBinding in Gradle configs
- Eliminates
kotlin-android-extensionsand migrates all activities to usebindingreferences - Adds custom time‐picker layouts and Java classes for second‐precision pickers
Reviewed Changes
Copilot reviewed 38 out of 39 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| gradle/wrapper/gradle-wrapper.properties | Bump Gradle distribution to 8.5 |
| gradle.properties | Suppress unsupported compileSdk 35 warning |
| app/build.gradle | Remove synthetic plugin, enable viewBinding |
| SSffmpegVideoOperation/build.gradle | Sync compileSdk/targetSdk to 35, add flatDir repo |
| app/src/main/res/values/strings.xml | Add time‐picker string resources |
| app/src/main/res/layout/*.xml | Introduce time picker widget & dialog layouts |
**/*Activity.kt |
Remove synthetic imports, add binding setup |
| BaseActivity.kt | Defer setContentView to child activities |
Comments suppressed due to low confidence (1)
app/src/main/res/values/strings.xml:114
- XML comments must use rather than //, or remove this line, as // will break resource compilation.
// Time Picker
app/src/main/java/com/simform/videoimageeditor/videoProcessActivity/CombineVideosActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/simform/videoimageeditor/videoProcessActivity/CombineImagesActivity.kt
Outdated
Show resolved
Hide resolved
Rajan-p-simform
force-pushed
the
feature/replace-kotlin-android-extensions-with-viewbinding
branch
2 times, most recently
from
de15d6c to
1d10c67
Compare
yashwantgowla-simform
requested changes
Jul 9, 2025
app/src/main/java/com/simform/videoimageeditor/middlewareActivity/VideoProcessActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/simform/videoimageeditor/videoProcessActivity/VideoRotateFlipActivity.kt
Outdated
Show resolved
Hide resolved
Rajan-p-simform
force-pushed
the
feature/replace-kotlin-android-extensions-with-viewbinding
branch
2 times, most recently
from
409089d to
208f8fe
Compare
Rajan-p-simform
force-pushed
the
feature/replace-kotlin-android-extensions-with-viewbinding
branch
from
208f8fe to
6677828
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to modernize the codebase, improve compatibility, and enhance maintainability. Key updates include upgrading SDK versions, transitioning from synthetic view binding to Android View Binding.
Build Configuration Updates:
SSffmpegVideoOperation/build.gradle: UpgradedcompileSdkto 35,targetSdkVersionto 35. Added aflatDirrepository for local libraries. [1] [2]app/build.gradle: UpdatedcompileSdkandtargetSdkVersionto 35, replacedkotlin-android-extensionswithviewBinding.View Binding Migration:
BaseActivity.kt: RemovedsetContentViewlogic from the base class to allow individual activities to set views using View Binding.MainActivity.kt,OtherFFMPEGProcessActivity.kt,VideoProcessActivity.kt,AudiosMergeActivity.kt).