Skip to content

Conversation

Rajan-p-simform
Copy link

Update Image to Video Conversion Query

This PR updates the FFmpeg query used for converting static images to video. The enhancement manages the failure case when the image's height and width are not even.

Changes
Modified the imageToVideo method in FFmpegQueryExtension to ensure width and height values are always even numbers, which prevents codec compatibility issues

Updated the audio Pick code to support latest android versions

@Rajan-p-simform Rajan-p-simform requested a review from Copilot July 7, 2025 06:39
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the FFmpeg image-to-video conversion to enforce even dimensions and modernizes media picking across the app for Android 13+.

  • Enforce even width/height in imageToVideo queries to avoid codec errors.
  • Replace Kotlin synthetic view access with ViewBinding and migrate to ActivityResultContracts for media selection.
  • Update Common.getFilePath for API 33+ storage handling, add helper methods for URI-based file access.

Reviewed Changes

Copilot reviewed 41 out of 42 changed files in this pull request and generated 1 comment.

File Description
SSffmpegVideoOperation/src/main/java/com/simform/videooperations/FFmpegQueryExtension.kt Ensure width and height are even in the image-to-video conversion.
SSffmpegVideoOperation/src/main/java/com/simform/videooperations/Common.kt Adapt output paths for Android 13+, add URI→file temp helper, duration retrieval.
app/src/main/res/values/strings.xml Added time-picker strings and an inline comment.
app/src/main/AndroidManifest.xml Updated READ_EXTERNAL_STORAGE permission with maxSdkVersion.
Comments suppressed due to low confidence (2)

app/src/main/res/values/strings.xml:114

  • XML resource comments should use syntax instead of //. The line '// Time Picker' will break resource parsing.
    // Time Picker

app/src/main/AndroidManifest.xml:7

  • The 'tools:ignore' attribute is used without declaring the 'xmlns:tools' namespace. Add xmlns:tools to the element to avoid manifest merge errors.
    <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE"

@Rajan-p-simform Rajan-p-simform force-pushed the feature/update-image-to-video-query branch from 10dbec7 to 4b7e490 Compare July 7, 2025 09:52
@Rajan-p-simform Rajan-p-simform force-pushed the feature/update-image-to-video-query branch from 4b7e490 to 353a2f4 Compare July 9, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant