Skip to content

Conversation

Rajan-p-simform
Copy link

Provide options to choose watermark positions.
eg. center, fill, crop, top-left, top-right, bottom-left, bottom-right

@Rajan-p-simform Rajan-p-simform requested a review from Copilot July 8, 2025 05:14
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds configurable watermark positioning and modernizes UI components across activities.

  • Introduce a spinner in AddWaterMarkOnVideoActivity to select watermark position (custom, center, fill, crop, corners).
  • Update AddWaterMarkOnVideoActivity logic to pass the chosen position or custom X/Y coordinates to the FFmpeg query.
  • Migrate from Kotlin synthetics to view binding, add a common toolbar include, and enable edge-to-edge layouts.

Reviewed Changes

Copilot reviewed 79 out of 81 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
app/src/main/res/layout/activity_add_water_mark_on_video.xml Added spinner for watermark position options.
app/src/main/java/com/simform/videoimageeditor/.../AddWaterMarkOnVideoActivity.kt Setup spinner and pass position params to the query.
app/src/main/res/layout/toolbar_app.xml New reusable MaterialToolbar layout.
app/src/main/java/com/simform/videoimageeditor/utils/ExtensionsUtils.kt Added enableEdgeToEdge extension for activities.
app/src/main/res/values/themes.xml Switched to NoActionBar to support custom toolbar.
Comments suppressed due to low confidence (3)

app/src/main/res/values/strings.xml:114

  • XML resource files should use XML comments (<!-- ... -->) instead of //. Replace this line with an XML comment or remove it.
    // Time Picker

app/src/main/res/layout/time_picker_widget.xml:18

  • This line appears to be a stray Java comment terminator inside XML. Remove or wrap the license header in valid XML comments.
*/

app/src/main/res/layout/activity_change_audio_valume.xml:1

  • [nitpick] The file and binding class use valume instead of volume; consider renaming to activity_change_audio_volume.xml and updating the corresponding binding.
<?xml version="1.0" encoding="utf-8"?>

@Rajan-p-simform Rajan-p-simform force-pushed the feature/options-for-watermark-positions branch from dcfb261 to acc755b Compare July 8, 2025 05:22
@Rajan-p-simform Rajan-p-simform force-pushed the feature/options-for-watermark-positions branch from acc755b to fdab622 Compare July 15, 2025 11:43
@Rajan-p-simform Rajan-p-simform force-pushed the feature/options-for-watermark-positions branch from fdab622 to 6735566 Compare July 15, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant