-
Notifications
You must be signed in to change notification settings - Fork 89
Provide options to choose watermark positions. #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Provide options to choose watermark positions. #69
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds configurable watermark positioning and modernizes UI components across activities.
- Introduce a spinner in AddWaterMarkOnVideoActivity to select watermark position (custom, center, fill, crop, corners).
- Update AddWaterMarkOnVideoActivity logic to pass the chosen position or custom X/Y coordinates to the FFmpeg query.
- Migrate from Kotlin synthetics to view binding, add a common toolbar include, and enable edge-to-edge layouts.
Reviewed Changes
Copilot reviewed 79 out of 81 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
app/src/main/res/layout/activity_add_water_mark_on_video.xml | Added spinner for watermark position options. |
app/src/main/java/com/simform/videoimageeditor/.../AddWaterMarkOnVideoActivity.kt | Setup spinner and pass position params to the query. |
app/src/main/res/layout/toolbar_app.xml | New reusable MaterialToolbar layout. |
app/src/main/java/com/simform/videoimageeditor/utils/ExtensionsUtils.kt | Added enableEdgeToEdge extension for activities. |
app/src/main/res/values/themes.xml | Switched to NoActionBar to support custom toolbar. |
Comments suppressed due to low confidence (3)
app/src/main/res/values/strings.xml:114
- XML resource files should use XML comments (
<!-- ... -->
) instead of//
. Replace this line with an XML comment or remove it.
// Time Picker
app/src/main/res/layout/time_picker_widget.xml:18
- This line appears to be a stray Java comment terminator inside XML. Remove or wrap the license header in valid XML comments.
*/
app/src/main/res/layout/activity_change_audio_valume.xml:1
- [nitpick] The file and binding class use
valume
instead ofvolume
; consider renaming toactivity_change_audio_volume.xml
and updating the corresponding binding.
<?xml version="1.0" encoding="utf-8"?>
...src/main/java/com/simform/videoimageeditor/videoProcessActivity/CutVideoUsingTimeActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/simform/videoimageeditor/videoProcessActivity/CompressVideoActivity.kt
Outdated
Show resolved
Hide resolved
dcfb261
to
acc755b
Compare
acc755b
to
fdab622
Compare
fdab622
to
6735566
Compare
Provide options to choose watermark positions.
eg. center, fill, crop, top-left, top-right, bottom-left, bottom-right