Part 2 - Tool Deep Linking: request validation, content items, and signed responses#43
Open
Part 2 - Tool Deep Linking: request validation, content items, and signed responses#43
Conversation
Implement core refactor
* docs refactor * docs * implement tool deep linking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds complete tool-side Deep Linking support on top of the core refactor. It validates
LtiDeepLinkingRequestlaunches, parses typed deep-linking settings, builds validated content items, and generates signed deep-linking
response JWTs.
This PR should be reviewed and landed after #42
What Changed
Lti_1p3.Tool.validate_deep_linking_request/1Lti_1p3.Tool.deep_linking_content_item/2Lti_1p3.Tool.build_deep_linking_response/3Lti_1p3.DeepLinking.ClaimKeysWhy
The core PR establishes launch correctness and message dispatch, but deep-linking flows still need request validation
and response generation. This PR closes that gap with a typed, explicit API that is ready for real LMS
interoperability work.
Reviewer Notes
Focus review on:
Most of the diff against
masteris inherited from PR 1. The incremental review surface here is the newTool.DeepLinkingmodules and the dispatch wiring.Documentation
docs/tool_deep_linking_guide.mddocs/features/tool-deep-linking/*README.mdCHANGELOG.md