Skip to content

DefaultOperations.java - Add blank string default #7712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: dev/feature
Choose a base branch
from
Draft

DefaultOperations.java - Add blank string default #7712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1697818
DefaultOperations.java - Add blank string default
Fusezion Mar 16, 2025
5276068
Fix test failing - forgot to test them
Fusezion Mar 16, 2025
93cfc8c
Merge branch 'dev/feature' into enhancement/null-equals-empty-string
Fusezion Mar 18, 2025
eb04654
Merge branch 'dev/feature' into enhancement/null-equals-empty-string
Fusezion Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/java/ch/njol/skript/classes/data/DefaultOperations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ public class DefaultOperations {
Arithmetics.registerDifference(Date.class, Timespan.class, Date::difference);

// String - String
Arithmetics.registerDefaultValue(String.class, () -> "");
Arithmetics.registerOperation(Operator.ADDITION, String.class, String.class, String::concat);

}
Expand Down
2 changes: 1 addition & 1 deletion src/test/skript/tests/regressions/7164-expressions sometimes dont convert.sk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ test "expressions sometimes dont convert":
assert formatted ({_foo} + {_bar}) is not set with "formatting nothing shouldn't throw an error"

set {_foo} to "test"
assert formatted ({_foo} + {_bar}) is not set with "formatting string + none shouldn't throw an error"
assert formatted ({_foo} + {_bar}) is "test" with "formatting string + none shouldn't throw an error"

set {_foo} to 1
set {_bar} to 2
Expand Down