Skip to content

Strider Support #7748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 3, 2025
Merged

Conversation

Absolutionism
Copy link
Contributor

Description

This PR aims to add strider support by checking to see if a strider is shivering and setting the shivering state.


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@Absolutionism Absolutionism requested a review from a team as a code owner March 25, 2025 04:56
@Absolutionism Absolutionism requested review from Pesekjak and cheeezburga and removed request for a team March 25, 2025 04:56
Copy link
Contributor

@Fusezion Fusezion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts about adding entity data for spawn a shivering strider?

@Efnilite Efnilite added the feature Pull request adding a new feature. label Mar 25, 2025
@Fusezion

This comment was marked as resolved.

@Absolutionism Absolutionism requested a review from Fusezion March 27, 2025 04:25
@ShaneBeee
Copy link
Contributor

ShaneBeee commented Apr 10, 2025

I want to make note that the EntityData for this is going to virtually be useless.
Regarding setShivering from the java docs:
"Note that the shivering state is updated frequently on the server, therefore this method may not affect the entity for long enough to have a noticeable difference."

Essentially the server is going to update the Strider almost immediately that this will appear to "not work" and someone is bound to report it as a bug.

Same goes for the effect to make them shiver.

Edit: Yeah, it basically does nothing. You can see it flash for a quick tick, and thats about it:

Screen.Recording.2025-04-09.at.10.14.08.PM.mov

@sovdeeth sovdeeth moved this to In Review in 2.12 Release May 14, 2025
@skriptlang-automation skriptlang-automation bot added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label May 14, 2025
@sovdeeth sovdeeth merged commit efbde8d into SkriptLang:dev/feature Jun 3, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Awaiting Merge to Done in 2.12 Release Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull request adding a new feature. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants