Skip to content

Remove 1.16-1.18 Reflection Checks #7832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: dev/patch
Choose a base branch
from
Open

Remove 1.16-1.18 Reflection Checks #7832

wants to merge 4 commits into from

Conversation

erenkarakal
Copy link
Member

Description

  • Removes class/field/methodExists() reflection checks that only fail on unsupported versions, mostly 1.16-1.18, with a few even older versions.
  • The docs were untouched. I think it should be kept that way, but I can clean them up as well.
  • Added remove this when Spigot support is dropped comments above Paper only checks

Target Minecraft Versions: any
Requirements: none
Related Issues: none

@erenkarakal erenkarakal requested review from sovdeeth and a team as code owners April 25, 2025 14:00
@erenkarakal erenkarakal requested review from UnderscoreTud and removed request for a team April 25, 2025 14:00
@erenkarakal erenkarakal added the housekeeping Housekeeping-related issue or task. label Apr 25, 2025
@Efnilite Efnilite added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Apr 29, 2025
APickledWalrus
APickledWalrus approved these changes May 1, 2025
View reviewed changes
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We might want to remove the outdated RequiredPlugins docs annotation as well (e.g. those that are like "Minecraft 1.18+")

@sovdeeth sovdeeth marked this pull request as draft May 14, 2025 21:42
@sovdeeth sovdeeth marked this pull request as ready for review May 14, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sovdeeth sovdeeth sovdeeth approved these changes

@APickledWalrus APickledWalrus APickledWalrus approved these changes

@Efnilite Efnilite Efnilite approved these changes

@UnderscoreTud UnderscoreTud Awaiting requested review from UnderscoreTud UnderscoreTud is a code owner automatically assigned from SkriptLang/core-developers

Assignees
No one assigned
Labels
housekeeping Housekeeping-related issue or task. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erenkarakal @sovdeeth @APickledWalrus @Efnilite