Syntax Simplification

[sovdeeth]

Description

Skript has always had this little method on Expression called simplify(), which has never been implemented. It's intended to take expressions and, if possible, simplify them to Literals or similarly simplify the code tree.
This PR attempts to properly implement that idea via a Simplifiable interface. A config option is added to allow users to opt out if issues arise.

Every element is simplified immediately after init() in SkriptParser. In addition, it may be called at any time by parent elements, though it should be ensured that no other objects maintain critical references to the element, as simplify may return new objects.

ExprArithmetic is a special case that can only be simplified once all elements in the chain have been parsed and ordered, so it requires checking the ParsingStack to see if it's the top-level element in the chain. If so, it can then call simplify recursively on all elements in the chain.

Todo:

• Properly simplify ConvertedExpressions. The existing method was stripping the converting part off a lot of converted expressions.
• Implement simplify on many more expressions that could support it.

---

Target Minecraft Versions: any
Requirements: none
Related Issues: none

[APickledWalrus]

Looking good so far. Do you think Arithmetic tests that verify the SyntaxElement is a Literal would be possible?

[APickledWalrus]

Looking really good. I might prefer to see the classes of the new simplification package under ch.njol. Mainly, given that rewritten classes are possible in the future, it'll make compatibility easier to handle

[Burbulinis]

looks good to me, although aren't there more expressions that can implement simplify under org/skriptlang/skript/?

[Burbulinis]

should we mention what it was simplified to?

[sovdeeth]

I think that would get rather confusing, the toString's already rather busy.

[APickledWalrus]

Looks good. Re-request after conflict resolution for approval 🙂