-
-
Notifications
You must be signed in to change notification settings - Fork 390
Pig Variants #7846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev/feature
Are you sure you want to change the base?
Pig Variants #7846
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see some debug/testmode warnings when registries aren't found
Specifically when reflection fails, rather than classes not existing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Description
This PR aims to add support for Pig Variants.
By doing so, this PR adds:
BukkitClasses#getRegistryClassInfo
: Which checks if the variant class exists and is present within either Bukkit's or Paper's Registry. Then proceeds to return aRegistryClassInfo
if found or a filler/dummyClassInfo
PaperUtils
: Utils class for Paper related stuff#registryExists
: Same asBukkitUtils#registryExists
but checks in Paper's Registry#getBukkitRegistry
: Gets the Bukkit Registry version of a Paper RegistryTarget Minecraft Versions: any
Requirements: none
Related Issues: none