Skip to content

Pig Variants #7846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: dev/feature
Choose a base branch
from

Conversation

Absolutionism
Copy link
Contributor

Description

This PR aims to add support for Pig Variants.
By doing so, this PR adds:

  • BukkitClasses#getRegistryClassInfo : Which checks if the variant class exists and is present within either Bukkit's or Paper's Registry. Then proceeds to return a RegistryClassInfo if found or a filler/dummy ClassInfo
  • PaperUtils : Utils class for Paper related stuff
    • #registryExists : Same as BukkitUtils#registryExists but checks in Paper's Registry
    • #getBukkitRegistry : Gets the Bukkit Registry version of a Paper Registry

Target Minecraft Versions: any
Requirements: none
Related Issues: none

@Absolutionism Absolutionism requested a review from a team as a code owner May 1, 2025 21:28
@Absolutionism Absolutionism requested review from sovdeeth and Efnilite and removed request for a team May 1, 2025 21:28
@sovdeeth sovdeeth added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label May 1, 2025
@Absolutionism Absolutionism requested a review from sovdeeth May 2, 2025 02:42
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see some debug/testmode warnings when registries aren't found
Specifically when reflection fails, rather than classes not existing.

@Absolutionism Absolutionism requested a review from sovdeeth May 5, 2025 01:13
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@sovdeeth sovdeeth added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants