Fix ExprHash internal error when MD5 is used#8609
Open
Dev-Xeiji wants to merge 3 commits intoSkriptLang:dev/patchfrom
Open
Fix ExprHash internal error when MD5 is used#8609Dev-Xeiji wants to merge 3 commits intoSkriptLang:dev/patchfrom
Dev-Xeiji wants to merge 3 commits intoSkriptLang:dev/patchfrom
Conversation
Added exception handling for MD5 warning suppression.
Dev-Xeiji
requested review from
UnderscoreTud and
erenkarakal
and removed request for
a team
bluelhf
suggested changes
May 1, 2026
Contributor
There was a problem hiding this comment.
This should use the approach suggested by @APickledWalrus with a condition rather than try-catch, because we don't want to suppress other types of exceptions and because the code for that will look cleaner.
Author
Ohh alright, I was just actually looking to some related file when doing this, that resulted on this approach. Will go update it to what's suggested |
Replaced try-catch with parser checker
skriptlang-automation
Bot
added
the
needs reviews
APickledWalrus
approved these changes
May 5, 2026
Member
APickledWalrus
left a comment
APickledWalrus
left a comment
There was a problem hiding this comment.
I might save the result of getParser() rather than call it twice, but this looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added exception handling for MD5 warning suppression.
Problem
#8474 (Error was caused by trying to give the warning, regards with @bluelhf)
Solution
Adopted the recommended fix by @APickledWalrus #8474 (comment)
Testing Completed
Supporting Information
Completes: #8474
Related: none
AI assistance: none