Fix EffKick, EffBan component support#8628
Open
APickledWalrus wants to merge 1 commit intodev/patchfrom
Open
Conversation
APickledWalrus
requested review from
cheeezburga and
erenkarakal
and removed request for
a team
APickledWalrus
added
bug
skriptlang-automation
Bot
added
the
needs reviews
This comment has been minimized.
This comment has been minimized.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
While ExprKickMessage supports components, EffKick does not. EffBan, which has a kick option, does not either. EffBan reasons also no longer process legacy formatting by default.
Solution
Refactors EffKick and EffBan with component support. Ban entries do not currently support Components, so a legacy conversion is performed. It is not a goal to improve the behavior (i.e. deprecated BanList usages) of EffBan.
Testing Completed
Manual in game testing.
Supporting Information
n/a
Completes:
Related: none
AI assistance: none