Skip to content

STYLE: "become" #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

STYLE: "become" #689

wants to merge 1 commit into from

Conversation

tdiprima
Copy link

Please consider this small fix. Changed "be come" to "become".
Thank you :)

Changed "be come" to "become".
@jcfr
Copy link
Member

jcfr commented Mar 22, 2017

Thanks for the fix 👍

Integrated in r25860

@jcfr jcfr closed this Mar 22, 2017
@lassoan
Copy link
Contributor

lassoan commented Mar 22, 2017

Note that this is template is for the old editor module. Template for the current segment editor is available here:
https://github.com/Slicer/Slicer/tree/master/Utilities/Templates/Modules/ScriptedSegmentEditorEffect
The easiest way to use it is to run the ExtensionWizard module in Slicer to generate an extension and within that add a 'scriptedsegmenteditoreffect' module.

@lassoan
Copy link
Contributor

lassoan commented Mar 22, 2017

@jcfr Duplication between [1] and [2] is confusing and difficult to maintain. Should we change extension testing to use [1] and delete [2]; or change extension wizard to use [2] and delete [1]?

[1] https://github.com/Slicer/Slicer/tree/master/Utilities/Templates/Modules
[2] https://github.com/Slicer/Slicer/tree/master/Extensions/Testing

@jcfr
Copy link
Member

jcfr commented Mar 22, 2017

Templates in https://github.com/Slicer/Slicer/tree/master/Extensions/Testing are full example integrating multiple modules that are automatically generated using the Slicer templates generator targets.

See here for more details: Slicer/Slicer#493 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants