Fix NPE error caused by the second HID endpoint of HID composite devices#1808
Open
KenRouKoro wants to merge 1 commit intoSlimeVR:mainfrom
Open
Fix NPE error caused by the second HID endpoint of HID composite devices#1808KenRouKoro wants to merge 1 commit intoSlimeVR:mainfrom
KenRouKoro wants to merge 1 commit intoSlimeVR:mainfrom
Conversation
KenRouKoro
requested review from
ButterscotchV,
Eirenliel and
Erimelowo
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a NullPointerException in the hid4java data reader and device enumerator threads that occurs when a single USB device enumerates multiple HID interfaces (with identical VID/PID/serial numbers) due to the physical device having a second HID endpoint, which previously prevented the receiver's tracking data from being recognized.
Additionally, it resolves a secondary issue introduced by the initial fix: if the second HID endpoint is not a SlimeVR HID endpoint, it causes a loop of
[TrackerServer] Reopening device ${device.serialNumber} after no data received. This happens because the system attempts to handshake with the second HID endpoint as if it were a SlimeVR device, despite there being no corresponding return data. To address this, I have introduced akeepFirstHidPerPhysicalDevicefilter to block extra HID endpoints.