Skip to content

Wiszb 120/121 add support #2092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

marcintyminski
Copy link

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

Copy link

Duplicate profile check: Passed - no duplicate profiles detected.

Copy link

github-actions bot commented Apr 24, 2025

Test Results

   66 files  ± 0    426 suites  +1   0s ⏱️ ±0s
2 183 tests + 8  2 183 ✅ + 8  0 💤 ±0  0 ❌ ±0 
3 724 runs  +16  3 724 ✅ +16  0 💤 ±0  0 ❌ ±0 

Results for commit ab55b96. ± Comparison against base commit d773c03.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 24, 2025

File Coverage
All files 99%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-contact/src/smartsense-multi/init.lua 95%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-contact/src/multi-sensor/init.lua 97%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-contact/src/init.lua 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-contact/src/frient/init.lua 98%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against ab55b96

@greens
Copy link
Contributor

greens commented Apr 24, 2025

Checking drivers/SmartThings/zigbee-contact/src/test/test_frient_contact_sensor.lua 4 warnings

    drivers/SmartThings/zigbee-contact/src/test/test_frient_contact_sensor.lua:24:7: (W211) unused variable TemperatureMeasurement
    drivers/SmartThings/zigbee-contact/src/test/test_frient_contact_sensor.lua:26:7: (W211) unused variable IASCIEAddress
    drivers/SmartThings/zigbee-contact/src/test/test_frient_contact_sensor.lua:27:7: (W211) unused variable EnrollResponseCode
    drivers/SmartThings/zigbee-contact/src/test/test_frient_contact_sensor.lua:31:7: (W211) unused variable TEMPERATURE_MEASUREMENT_ENDPOINT

Checking drivers/SmartThings/zigbee-contact/src/test/test_frient_contact_sensor_pro.lua 2 warnings

    drivers/SmartThings/zigbee-contact/src/test/test_frient_contact_sensor_pro.lua:26:7: (W211) unused variable IASCIEAddress
    drivers/SmartThings/zigbee-contact/src/test/test_frient_contact_sensor_pro.lua:27:7: (W211) unused variable EnrollResponseCode

Checking drivers/SmartThings/zigbee-contact/src/frient/init.lua 1 warning

    drivers/SmartThings/zigbee-contact/src/frient/init.lua:23:7: (W211) unused variable DEFAULT_TEMPERATURE_SENSITIVITY

Copy link

@KKlimczukS KKlimczukS requested a review from greens May 7, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants