Skip to content

Matter RVC: Add mode id to supported_modes field #2108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 8, 2025
Merged

Matter RVC: Add mode id to supported_modes field #2108

merged 3 commits into from
May 8, 2025

Conversation

HunsupJung
Copy link
Collaborator

@HunsupJung HunsupJung commented May 1, 2025 •
edited
Loading

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

https://smartthings.atlassian.net/browse/IOTE-5115

Summary of Completed Tests

https://smartthings.atlassian.net/browse/IOTE-5115

@github-actions GitHub Actions
Copy link

github-actions bot commented May 1, 2025 •
edited
Loading

Channel deleted.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 1, 2025 •
edited
Loading

Test Results

   66 files  ±0    425 suites  ±0   0s ⏱️ ±0s
2 174 tests  - 1  2 174 ✅  - 1  0 💤 ±0  0 ❌ ±0 
3 707 runs   - 1  3 707 ✅  - 1  0 💤 ±0  0 ❌ ±0 

Results for commit 61b325e. ± Comparison against base commit d773c03.

This pull request removes 1 test. 
On changing the operatinalState to STOPPED, robotCleanerOperatingState must be set to the appropriate value

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 1, 2025 •
edited
Loading

File Coverage
All files 92% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/init.lua 92% ✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 61b325e

gharveymn
gharveymn reviewed May 1, 2025
View reviewed changes
drivers/SmartThings/matter-rvc/src/init.lua Outdated
@@ -175,10 +175,10 @@ local function run_mode_supported_mode_handler(driver, device, ib, response)
end
if tag ~= 0xFFFF then
table.insert(supported_modes, mode.elements.label.value)
table.insert(supported_modes_with_tag, {mode.elements.label.value, tag})
table.insert(supported_modes_id_tag, { mode.elements.label.value, mode.elements.mode.value, tag })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to turn this into a table so it's a bit more clear? Like { label = mode.elements.label.value, <etc...> }?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suggestion looks good to me. I will modify it.

@CLAassistant
Copy link

CLAassistant commented May 2, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@HunsupJung HunsupJung force-pushed the fix/matter-rvc-add-mode-id-to-field branch from 66db547 to 9bd03dc Compare May 7, 2025 09:18
HunsupJung and others added 2 commits May 7, 2025 18:34
@HunsupJung
Improve unit tests
2176cdd 
Signed-off-by: Gene Harvey <[email protected]>
@gharveymn @HunsupJung
Document test reasoning
61b325e 
Signed-off-by: Gene Harvey <[email protected]>
@HunsupJung HunsupJung force-pushed the fix/matter-rvc-add-mode-id-to-field branch from c2f9d30 to 61b325e Compare May 7, 2025 09:47
@HunsupJung
Copy link
Collaborator Author

@gharveymn
I pushed a commit with force option and your commits were deleted. So, I've restored it.
I'm so sorry for my mistake.

gharveymn
gharveymn approved these changes May 7, 2025
View reviewed changes
Copy link
Contributor

@gharveymn gharveymn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the adjustments. You can just squash my commits into yours.

@HunsupJung HunsupJung merged commit 5830ba1 into main May 8, 2025
11 checks passed
@HunsupJung HunsupJung deleted the fix/matter-rvc-add-mode-id-to-field branch May 8, 2025 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gharveymn gharveymn gharveymn approved these changes

@z-michel z-michel Awaiting requested review from z-michel

@hcarter-775 hcarter-775 Awaiting requested review from hcarter-775

@nickolas-deboom nickolas-deboom Awaiting requested review from nickolas-deboom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HunsupJung @CLAassistant @gharveymn