Skip to content

[Aqara] Update Aqara Door and Window Sensor T1 driver #2113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

seojune79
Copy link
Contributor

@seojune79 seojune79 commented May 7, 2025

…ol, changed capability from battery to batteryLevel, and applied battery info in status messages.

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

…ol, changed capability from battery to batteryLevel, and applied battery info in status messages.
Copy link

github-actions bot commented May 7, 2025

Duplicate profile check: Passed - no duplicate profiles detected.

Copy link

github-actions bot commented May 7, 2025

Copy link

github-actions bot commented May 7, 2025

Test Results

   66 files  ±0    425 suites  ±0   0s ⏱️ ±0s
2 180 tests +5  2 180 ✅ +5  0 💤 ±0  0 ❌ ±0 
3 713 runs  +5  3 713 ✅ +5  0 💤 ±0  0 ❌ ±0 

Results for commit 9a467fe. ± Comparison against base commit d773c03.

This pull request removes 2 and adds 7 tests. Note that renamed tests count towards both.
closed contact events
open contact events
battery status events - critical status
battery status events - normal status
battery status events - warning status
closed contact events - OnOff
doConfigure lifecycle handler
heartbeat battery events - critical status
heartbeat battery events - normal status

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 7, 2025

File Coverage
All files 99%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-contact/src/multi-sensor/init.lua 97%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-contact/src/init.lua 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-contact/src/smartsense-multi/init.lua 95%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 9a467fe

local PRIVATE_CLUSTER_ID = 0xFCC0
local PRIVATE_ATTRIBUTE_ID = 0x0009
local PRIVATE_HEART_BATTERY_ENERGY_ID = 0x00F7

local FINGERPRINTS = {
{ mfr = "LUMI", model = "lumi.magnet.agl02" }
}

local CONFIGURATIONS = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please add the configureReport for on/off cluster like...

{
cluster = OnOff.ID,
attribute = OnOff.attributes.OnOff.ID,
minimum_interval = 30,
maximum_interval = 3600,
data_type = OnOff.attributes.OnOff.base_type,
reportable_change = 1
},

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, added the corresponding configureReport for the On/Off cluster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants