Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid crash in release due to superview (second constraint) being nil #613

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid crash in release due to superview (second constraint) being nil #613

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions Masonry/MASViewConstraint.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,17 @@ - (void)install {
if (!self.firstViewAttribute.isSizeAttribute && !self.secondViewAttribute) {
secondLayoutItem = self.firstViewAttribute.view.superview;
secondLayoutAttribute = firstLayoutAttribute;

if (!secondLayoutItem) { // Don't continue to crash.
// 发送通知，让外界处理（在 Debug / Release 下生效）
NSString *reason = [NSString stringWithFormat:@"NSLayoutConstraint for %@: A multiplier of 0 or a nil second item together with a location for the first attribute creates an illegal constraint of a location equal to a constant. Location attributes must be specified in pairs.", self.firstViewAttribute.view];
NSException *exception = [[NSException alloc] initWithName:@"MasonryException" reason:reason userInfo:nil];
[[NSNotificationCenter defaultCenter] postNotificationName:@"AutoLayoutExceptionNotification" object:exception];

// 断言（在 Debug 下生效）
NSAssert(NO, reason);
return;
}
}

MASLayoutConstraint *layoutConstraint
Expand Down