Skip to content

Doug/fix manifest issue #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 19, 2025
Merged

Doug/fix manifest issue #56

merged 4 commits into from
Feb 19, 2025

Conversation

dacoburn
Copy link
Collaborator

Issue where manifestFiles can be non-existent with top_level packages. This can cause the CLI to error out incorrectly.

Root Cause

Some results from the diff endpoint can have package entries where the top level package does not have the manifestFiles attribute. The code was not accounting for this correctly.

Fix

Added an explicit check to account for this:

if hasattr(top_package, "manifestFiles") and top_package.manifestFiles:

Public Changelog

  • Added fix for if manifestFiles attribute is not present on a top level package

@dacoburn dacoburn added the Product Changelog New features for the public changelog label Feb 19, 2025
@dacoburn dacoburn requested a review from a team as a code owner February 19, 2025 19:56
@dacoburn dacoburn requested review from tmpvar and mikolalysenko and removed request for a team February 19, 2025 19:56
Copy link

github-actions bot commented Feb 19, 2025

🚀 Preview package published!

Install with:

pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socketsecurity==2.0.6.dev564

Docker image: socketdev/cli:pr-56

@dacoburn dacoburn merged commit 7b7089e into main Feb 19, 2025
6 checks passed
@dacoburn dacoburn deleted the doug/fix-manifest-issue branch February 19, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product Changelog New features for the public changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants