Skip to content

Return headers on request exception #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 27, 2025

Conversation

flowstate
Copy link
Contributor

  • Returning the headers, request path, and original status code on do_request exceptions
  • Bandaid for an issue with the get repos API where nextPage was 1 even if you already got all results
  • Fixed get repos issue where not passing kwargs would result in an empty object being returned

@flowstate flowstate requested a review from a team as a code owner February 26, 2025 01:30
@flowstate flowstate requested review from alxhotel, rchatrath7 and dacoburn and removed request for a team, alxhotel and rchatrath7 February 26, 2025 01:30
Copy link

github-actions bot commented Feb 26, 2025

🚀 Preview package published!

Install with:

pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socket-sdk-python==2.0.8.dev237

Copy link
Collaborator

@dacoburn dacoburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets chat about the format we're returning API responses in.

@flowstate flowstate merged commit fc24237 into main Feb 27, 2025
6 checks passed
@flowstate flowstate deleted the eric/return-headers-on-request-exception branch February 27, 2025 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants